[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/
-----------------------------------------------------------

(Updated 2011-03-16 08:40:59.045815)


Review request for Asterisk Developers, Russell Bryant, dimas, Leif Madsen, and dafe_von_cetin.


Changes
-------

Here is a functional T.38 Gateway has taken me a while but its here.

- No more hijacking of core loop and no replacement dial function all wrapped up into res_fax.
- both T.30 and T.38 sides are now using generator API to send improving reliability of T.30
- Changes to SIP T.38 negotiate from r1115 now moved here as they required can we close 1115 ??
- chan_sip has a t38switchover option that switches to T.38 if needed
- switchover code removed from the main loop does not belong there see above
- A generic faxdetect app that i use for testing i propose be put into res_fax ??
- Only start sending T.30 when we have a T.38 packet
- app_faxdetect answers the channel if not answered and listens for CNG/CED storing deferred packets and queuing a T.38 on detect.

see bellow for a example of SIP t38 switchover on faxdetect. 
[please note i have removed T.38 support from chan_local use the F option for ReceiveFAX]

  == Using UDPTL CoS mark 5
  == Using SIP RTP CoS mark 5
    -- Executing [0803 at faxtest:1] Set("SIP/0819-00000002", "FAXOPT(t38gateway)=yes") in new stack
    -- Executing [0803 at faxtest:2] Set("SIP/0819-00000002", "FAXOPT(ecm)=yes") in new stack
    -- Executing [0803 at faxtest:3] Dial("SIP/0819-00000002", "Local/0803 at faxin") in new stack
    -- Called 0803 at faxin
    -- Executing [0803 at faxin:1] Answer("Local/0803 at faxin-d3dc;2", "") in new stack
    -- Local/0803 at faxin-d3dc;1 answered SIP/0819-00000002
    -- Executing [0803 at faxin:2] Wait("Local/0803 at faxin-d3dc;2", "4") in new stack
    -- Running Gateway activestate=4 (SIP/0819-00000002) and inactivestate=0 (Local/0803 at faxin-d3dc;1)
    -- Executing [0803 at faxin:3] ReceiveFAX("Local/0803 at faxin-d3dc;2", "/var/spool/asterisk/fax/1300280412.9.tiff") in new stack
    -- Channel 'Local/0803 at faxin-d3dc;2' receiving FAX '/var/spool/asterisk/fax/1300280412.9.tiff'
  == Spawn extension (faxtest, 0803, 3) exited non-zero on 'SIP/0819-00000002'
    -- Connection Statistics
        Bit Rate :14400
        ECM : No
        Pages : 1

[faxtest]
exten => _X.,1,SET(FAXOPT(t38gateway)=yes)
exten => _X.,n,SET(FAXOPT(ecm)=yes)
exten => _X.,n,Dial(Local/${EXTEN}@faxin)
exten => _X.,n,Hangup

[faxin]
exten => _X.,1,Answer()
exten => _X.,n,Wait(4)
exten => _X.,n,ReceiveFAX(/var/spool/asterisk/fax/${CDR(linkedid)}.tiff)


Summary
-------

Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.

i have cleaned the code up substantially it is related to R459

hope this is found useful and aids in the goal to get it in 1.10.

Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.


This addresses bug 13405.
    https://issues.asterisk.org/view.php?id=13405


Diffs (updated)
-----

  /trunk/apps/app_faxdetect.c PRE-CREATION 
  /trunk/channels/chan_sip.c 310546 
  /trunk/channels/sip/include/sip.h 310546 
  /trunk/configs/res_fax.conf.sample 310546 
  /trunk/configs/sip.conf.sample 310546 
  /trunk/include/asterisk/channel.h 310546 
  /trunk/include/asterisk/res_fax.h 310546 
  /trunk/main/channel.c 310546 
  /trunk/res/res_fax.c 310546 
  /trunk/res/res_fax_spandsp.c 310546 

Diff: https://reviewboard.asterisk.org/r/1116/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110316/b66c117c/attachment.htm>