<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1116/">https://reviewboard.asterisk.org/r/1116/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Russell Bryant, dimas, Leif Madsen, and dafe_von_cetin.</div>
<div>By irroot.</div>
<p style="color: grey;"><i>Updated 2011-03-16 08:40:59.045815</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here is a functional T.38 Gateway has taken me a while but its here.
- No more hijacking of core loop and no replacement dial function all wrapped up into res_fax.
- both T.30 and T.38 sides are now using generator API to send improving reliability of T.30
- Changes to SIP T.38 negotiate from r1115 now moved here as they required can we close 1115 ??
- chan_sip has a t38switchover option that switches to T.38 if needed
- switchover code removed from the main loop does not belong there see above
- A generic faxdetect app that i use for testing i propose be put into res_fax ??
- Only start sending T.30 when we have a T.38 packet
- app_faxdetect answers the channel if not answered and listens for CNG/CED storing deferred packets and queuing a T.38 on detect.
see bellow for a example of SIP t38 switchover on faxdetect.
[please note i have removed T.38 support from chan_local use the F option for ReceiveFAX]
== Using UDPTL CoS mark 5
== Using SIP RTP CoS mark 5
-- Executing [0803@faxtest:1] Set("SIP/0819-00000002", "FAXOPT(t38gateway)=yes") in new stack
-- Executing [0803@faxtest:2] Set("SIP/0819-00000002", "FAXOPT(ecm)=yes") in new stack
-- Executing [0803@faxtest:3] Dial("SIP/0819-00000002", "Local/0803@faxin") in new stack
-- Called 0803@faxin
-- Executing [0803@faxin:1] Answer("Local/0803@faxin-d3dc;2", "") in new stack
-- Local/0803@faxin-d3dc;1 answered SIP/0819-00000002
-- Executing [0803@faxin:2] Wait("Local/0803@faxin-d3dc;2", "4") in new stack
-- Running Gateway activestate=4 (SIP/0819-00000002) and inactivestate=0 (Local/0803@faxin-d3dc;1)
-- Executing [0803@faxin:3] ReceiveFAX("Local/0803@faxin-d3dc;2", "/var/spool/asterisk/fax/1300280412.9.tiff") in new stack
-- Channel 'Local/0803@faxin-d3dc;2' receiving FAX '/var/spool/asterisk/fax/1300280412.9.tiff'
== Spawn extension (faxtest, 0803, 3) exited non-zero on 'SIP/0819-00000002'
-- Connection Statistics
Bit Rate :14400
ECM : No
Pages : 1
[faxtest]
exten => _X.,1,SET(FAXOPT(t38gateway)=yes)
exten => _X.,n,SET(FAXOPT(ecm)=yes)
exten => _X.,n,Dial(Local/${EXTEN}@faxin)
exten => _X.,n,Hangup
[faxin]
exten => _X.,1,Answer()
exten => _X.,n,Wait(4)
exten => _X.,n,ReceiveFAX(/var/spool/asterisk/fax/${CDR(linkedid)}.tiff)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.
i have cleaned the code up substantially it is related to R459
hope this is found useful and aids in the goal to get it in 1.10.
Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/view.php?id=13405">13405</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_faxdetect.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(310546)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(310546)</span></li>
<li>/trunk/configs/res_fax.conf.sample <span style="color: grey">(310546)</span></li>
<li>/trunk/configs/sip.conf.sample <span style="color: grey">(310546)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(310546)</span></li>
<li>/trunk/include/asterisk/res_fax.h <span style="color: grey">(310546)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(310546)</span></li>
<li>/trunk/res/res_fax.c <span style="color: grey">(310546)</span></li>
<li>/trunk/res/res_fax_spandsp.c <span style="color: grey">(310546)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1116/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>