[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[Bryant Zimmerman]

----------------------------------------
 From: "irroot" <reviewboard at asterisk.org>
Sent: Wednesday, March 09, 2011 11:27 AM
To: ", "Leif Madsen" <lmadsen at digium.com>, "Russell Bryant" 
<russell at digium.com>, dimas at dataart.com
Subject: Re: [asterisk-dev] [Code Review] Fax Gateway Implementation 
T30<->T38

                           This is an automatically generated e-mail. To 
reply, visit: https://reviewboard.asterisk.org/r/1116/ 	          

                                        Review request for Asterisk 
Developers, Russell Bryant, dimas, Leif Madsen, and dafe_von_cetin.         
    By irroot.             Updated 2011-03-09 10:26:09.130302             
Changes             
                                                                            
            Ok here is the latest patch i have been working on that   
1)removes all hijacking of the local loop. 2)uses a generator to keep the 
T.30 output synced and more stable 3)uses frame hooks for processing all 
T30/T38 packets 4)enhancement to FAXOPT adding a option to enable/disable 
the gateway 5)the app im using to switchover the connection [this 
functionality is also added to faxdetect in sip]  there is lots of clean up 
to do and making sure the stats are updated correctly the functionality is 
there and working.  Greg                         	                      

             Description              
                                                                            
            Hi there the patch that was going around circa 2008 to 
implement this in 1.4/1.6 app_fax has been moved to trunk [1.10] ive made 
some cleanups and moved it into res_fax res_fax_spandsp this is the 
framework and not production code unfortunately i have no means of testing 
it at the moment and require help.  i have cleaned the code up 
substantially it is related to R459  hope this is found useful and aids in 
the goal to get it in 1.10.  Adds application FaxGateway / FaxDetect Adds 
alternate bridge to Dial with new option.                         	         
             

             Bugs: 13405              Diffs (updated)                       
       /trunk/apps/app_faxdetect.c (PRE-CREATION)                  
/trunk/channels/chan_sip.c (310135)                  
/trunk/channels/sip/include/sip.h (310135)                  
/trunk/configs/res_fax.conf.sample (310135)                  
/trunk/configs/sip.conf.sample (310135)                  
/trunk/include/asterisk/channel.h (310135)                  
/trunk/include/asterisk/res_fax.h (310135)                  
/trunk/main/channel.c (310135)                  /trunk/res/res_fax.c 
(310135)                  /trunk/res/res_fax_spandsp.c (310135)             
              

View Diff             	          

  
----------------------------------------
 Sorry if this is not the right way to post this on a Code Review post but 
my question is in direct parallel to some of the fax changes. 

Will this effect the "F" option in any way that Kevin added to the 1.10 
tree?  We are using a backport he did of it in the 1.8 tree and I need to 
understand if any of these fax changes are likely to break this going 
forward in to 1.10.  Right now we are having a great challenge getting the 
"F" option patch moved forward to some of the newer 1.8 releases and it is 
trapping us on buggier 1.8 versions.

Thank you for any response.
Bryant
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110309/801d596f/attachment.htm>