<span style="font-family: Arial, Helvetica, sans-serif; font-size: 10pt"><br />
<span style="font-family: tahoma,arial,sans-serif; font-size: 10pt;"><hr width="100%" size="2" align="center" />
<b>From</b>: "irroot" <reviewboard@asterisk.org><br />
<b>Sent</b>: Wednesday, March 09, 2011 11:27 AM<br />
<b>To</b>: ", "Leif Madsen" <lmadsen@digium.com>, "Russell Bryant" <russell@digium.com>, dimas@dataart.com<br />
<b>Subject</b>: Re: [asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38</span><br />
<br />
<div style="font-family: verdana, arial, helvetica, sans-serif;">
<table width="100%" style="background-color: #f9f3c9;border: #c9c399 1px solid;" cellpadding="8">
<tbody>
<tr>
<td>This is an automatically generated e-mail. To reply, visit: <a href="https://reviewboard.asterisk.org/r/1116/">https://reviewboard.asterisk.org/r/1116/</a> </td>
</tr>
</tbody>
</table>
<br />
<table width="100%" style="background-image: url(https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png); background-color: #fefadf; background-repeat: repeat-x; background-position: left top;border: black 1px solid;" cellspacing="0" cellpadding="8">
<tbody>
<tr>
<td>
<div>Review request for Asterisk Developers, Russell Bryant, dimas, Leif Madsen, and dafe_von_cetin.</div>
<div>By irroot.</div>
<p style="color: grey;"><i>Updated 2011-03-09 10:26:09.130302</i></p>
<h1 style="margin-top: 1.5em; color: #575012; font-size: 10pt;">Changes</h1>
<table width="100%" style="background-color: #ffffff;border: #b8b5a0 1px solid;" cellspacing="0" cellpadding="10">
<tbody>
<tr>
<td>
<pre style="padding-bottom: 0px; margin: 0px; padding-left: 0px; padding-right: 0px; word-wrap: break-word; padding-top: 0px;">Ok here is the latest patch i have been working on that
1)removes all hijacking of the local loop.
2)uses a generator to keep the T.30 output synced and more stable
3)uses frame hooks for processing all T30/T38 packets
4)enhancement to FAXOPT adding a option to enable/disable the gateway
5)the app im using to switchover the connection [this functionality is also added to faxdetect in sip]
there is lots of clean up to do and making sure the stats are updated correctly the functionality is there and working.
Greg</pre>
</td>
</tr>
</tbody>
</table>
<h1 style="margin-top: 1.5em; color: #575012; font-size: 10pt;">Description </h1>
<table width="100%" style="background-color: #ffffff;border: #b8b5a0 1px solid;" cellspacing="0" cellpadding="10">
<tbody>
<tr>
<td>
<pre style="padding-bottom: 0px; margin: 0px; padding-left: 0px; padding-right: 0px; word-wrap: break-word; padding-top: 0px;">Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.
i have cleaned the code up substantially it is related to R459
hope this is found useful and aids in the goal to get it in 1.10.
Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.</pre>
</td>
</tr>
</tbody>
</table>
<div style="margin-top: 1.5em;"><b style="margin-top: 1.5em; color: #575012; font-size: 10pt;">Bugs: </b><a href="https://issues.asterisk.org/view.php?id=13405">13405</a> </div>
<h1 style="margin-top: 1.5em; color: #575012; font-size: 10pt;">Diffs (updated)</h1>
<ul style="padding-left: 0px; margin-left: 3em;">
<li>/trunk/apps/app_faxdetect.c <span style="color: #808080;">(PRE-CREATION)</span> </li>
<li>/trunk/channels/chan_sip.c <span style="color: #808080;">(310135)</span> </li>
<li>/trunk/channels/sip/include/sip.h <span style="color: #808080;">(310135)</span> </li>
<li>/trunk/configs/res_fax.conf.sample <span style="color: #808080;">(310135)</span> </li>
<li>/trunk/configs/sip.conf.sample <span style="color: #808080;">(310135)</span> </li>
<li>/trunk/include/asterisk/channel.h <span style="color: #808080;">(310135)</span> </li>
<li>/trunk/include/asterisk/res_fax.h <span style="color: #808080;">(310135)</span> </li>
<li>/trunk/main/channel.c <span style="color: #808080;">(310135)</span> </li>
<li>/trunk/res/res_fax.c <span style="color: #808080;">(310135)</span> </li>
<li>/trunk/res/res_fax_spandsp.c <span style="color: #808080;">(310135)</span> </li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1116/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
<br />
<span style="font-family: tahoma; font-size: 13px;"> </span> <hr width="100%" size="2" align="center" />
Sorry if this is not the right way to post this on a Code Review post but my question is in direct parallel to some of the fax changes. <br />
<br />
Will this effect the "F" option in any way that Kevin added to the 1.10 tree? We are using a backport he did of it in the 1.8 tree and I need to understand if any of these fax changes are likely to break this going forward in to 1.10. Right now we are having a great challenge getting the "F" option patch moved forward to some of the newer 1.8 releases and it is trapping us on buggier 1.8 versions.<br />
<br />
Thank you for any response.<br />
Bryant</span>