[asterisk-dev] [Code Review] Segfault on shutdown when confbridge is active

[opticron]

> On 2011-06-27 11:10:32, David Vossel wrote:
> > trunk/apps/app_confbridge.c, lines 1041-1071
> > <https://reviewboard.asterisk.org/r/1283/diff/2/?file=17261#file17261line1041>
> >
> >     Out of curiosity, is this crash occurring just because the "underlying channel" is NULL in this function?  If so we should be able to detect that and exit from this function without trying to play a file to a non existent channel.

Actually, I think underlying_channel is a dangling pointer to a nulled out channel.  The actual segfault occurs when dereferencing a null tech in ast_channel_setoption.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1283/#review3779
-----------------------------------------------------------


On 2011-06-27 09:34:08, opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1283/
> -----------------------------------------------------------
> 
> (Updated 2011-06-27 09:34:08)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When undergoing a shutdown and channels are kicked out of a bridge, a segfault occurs because ConfBridge tries to play sounds on the bridge after the underlying channels have been blown away due to the shutdown.  This patch prevents ConfBridge from playing any additional sounds if Asterisk is shutting down.
> 
> 
> This addresses bug ASTERISK-18040.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18040
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_confbridge.c 324709 
> 
> Diff: https://reviewboard.asterisk.org/r/1283/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110628/c20372a9/attachment-0001.htm>