[asterisk-dev] [Code Review] Segfault on shutdown when confbridge is active

David Vossel reviewboard at asterisk.org
Mon Jun 27 11:10:32 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1283/#review3779
-----------------------------------------------------------



trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1283/#comment7578>

    Out of curiosity, is this crash occurring just because the "underlying channel" is NULL in this function?  If so we should be able to detect that and exit from this function without trying to play a file to a non existent channel.


- David


On 2011-06-27 09:34:08, opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1283/
> -----------------------------------------------------------
> 
> (Updated 2011-06-27 09:34:08)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When undergoing a shutdown and channels are kicked out of a bridge, a segfault occurs because ConfBridge tries to play sounds on the bridge after the underlying channels have been blown away due to the shutdown.  This patch prevents ConfBridge from playing any additional sounds if Asterisk is shutting down.
> 
> 
> This addresses bug ASTERISK-18040.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18040
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_confbridge.c 324709 
> 
> Diff: https://reviewboard.asterisk.org/r/1283/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110627/e1fe617b/attachment-0001.htm>


More information about the asterisk-dev mailing list