[asterisk-dev] [Code Review] app_queue Add Login Time and Last Paused Times to Queue Members

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1297/#review3781
-----------------------------------------------------------


Some cases missing ...

When a member is added he can be paused (create_queue_member) ....
Realtime members may be loaded paused likewise (rt_handle_member_record) ...
Dynamic members loaded from ASTDB on module load (reload_queue_members) ...

either the time needs to be cached astdb/rt or paused time = current time i favor the latter.

Use of formated date/time string breaks location / locale expectations rather output the login time in seconds
and have the user parse/format it.

this fits in nicely with my autopausedelay proposal that gives agents a grace time before pausing them.

the last paused time and login time i am able to retrieve from queue_log [SQL] there is a requirement for this
in AMI.

id also suggest setting the login duration in a data field of queue_log on log out to complete the logout message.

- irroot


On 2011-06-27 16:52:05, jamuel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1297/
> -----------------------------------------------------------
> 
> (Updated 2011-06-27 16:52:05)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds logintime and lastpaused as time values (type time_t) to the queue member structure.  These values are updated when a relevant event occurs for the member (e.g. member add and member pause).
> 
> The CLI command "queue show" and the AMI action "QueueStatus" have been updated to present these values.
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/trunk/apps/app_queue.c 324913 
> 
> Diff: https://reviewboard.asterisk.org/r/1297/diff
> 
> 
> Testing
> -------
> 
> Added a member to queue and issued queue show and AMI Action: QueueStatus and see the the LoginTime timestamp.
> Paused a member and issued queue show and AMI Action: QueueStatus and see the correct LastPaused timestamp.
> 
> 
> Thanks,
> 
> jamuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110628/f09dc4ec/attachment.htm>