<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1297/">https://reviewboard.asterisk.org/r/1297/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some cases missing ...
When a member is added he can be paused (create_queue_member) ....
Realtime members may be loaded paused likewise (rt_handle_member_record) ...
Dynamic members loaded from ASTDB on module load (reload_queue_members) ...
either the time needs to be cached astdb/rt or paused time = current time i favor the latter.
Use of formated date/time string breaks location / locale expectations rather output the login time in seconds
and have the user parse/format it.
this fits in nicely with my autopausedelay proposal that gives agents a grace time before pausing them.
the last paused time and login time i am able to retrieve from queue_log [SQL] there is a requirement for this
in AMI.
id also suggest setting the login duration in a data field of queue_log on log out to complete the logout message.</pre>
<br />
<p>- irroot</p>
<br />
<p>On June 27th, 2011, 4:52 p.m., jamuel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By jamuel.</div>
<p style="color: grey;"><i>Updated 2011-06-27 16:52:05</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds logintime and lastpaused as time values (type time_t) to the queue member structure. These values are updated when a relevant event occurs for the member (e.g. member add and member pause).
The CLI command "queue show" and the AMI action "QueueStatus" have been updated to present these values.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a member to queue and issued queue show and AMI Action: QueueStatus and see the the LoginTime timestamp.
Paused a member and issued queue show and AMI Action: QueueStatus and see the correct LastPaused timestamp.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>http://svn.asterisk.org/svn/asterisk/trunk/apps/app_queue.c <span style="color: grey">(324913)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1297/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>