[asterisk-dev] [Code Review] Remove skinny do_monitor and use ast_sched_start instead

wedhorn reviewboard at asterisk.org
Tue Jun 7 16:19:53 CDT 2011

This is an automatically generated e-mail. To reply, visit:

(Updated 2011-06-07 16:19:52.949958)

Review request for Asterisk Developers.


Modified ast_sched_start_thread to mirror chan_iax2 handling.


Review is predominantly to check that I'm correctly setting up the ast_sched_ stuff.

The do_monitor seemed to be there for task scheduling and network monitoring. However, the network monitoring has a dedicated thread so the ast_io_wait was basically just a usleep as it didn't actually seem to be monitoring anything. Using the inbuilt sched handling means we can now schedule task pretty much immediately rather than waiting for up to 1 second. When ast_sched_add is called, the sched thread is notified and reruns.

This is a precursor to adding additional scheduling tasks into skinny, namely rtp_timeout, autoanswer after a delay and cfwdnoanswer. Also plan to rewrite the simpleswitch to use timeout scheduling rather than a dedicated thread.

Diffs (updated)

  trunk/channels/chan_skinny.c 319583 

Diff: https://reviewboard.asterisk.org/r/1256/diff


Tested on skinny 7960 and 30VIPs. Tested dummy ast_sched_add and it worked.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110607/2a5a003f/attachment.htm>

More information about the asterisk-dev mailing list