[asterisk-dev] [Code Review] app_queue: skill routing

Tue Jun 7 02:05:16 CDT 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1096/#review3684
-----------------------------------------------------------

Have not tested it only looked through the code.

the recomended changes will be in /team/irroot/app_queue_skill

ill be commiting once i have built it with dev mode.

Regards Greg

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7374>

    Maintain formating.

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7375>

    Same.

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7373>

    /* has special meaning and should not be used in that combination or */

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7376>

    Maintain formating

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7432>

    Red Blocks

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7379>

    qe is checked in member_is_selected no need to test it here too

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7433>

    Red Blocks

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7434>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7435>

    Red Blocks

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7380>

    This has been changed in trunk and is a conflict.

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7436>

    Red Blocks And Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7381>

    Changed and now in conflict.

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7382>

    Changed and now in conflict.

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7383>

    Missing Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7384>

    Missing braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7385>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7386>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7387>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7388>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7390>

    Braces
    Space after for

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7391>

    Braces.
    Space after if

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7392>

    Formating braces and remove nl

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7393>

    Formating Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7394>

    Formating 

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7395>

    Formating

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7396>

    Formating Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7397>

    Formating

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7398>

    Formating

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7399>

    Formating

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7400>

    Eish .... some formating ill try figgure this out latter when i get to functionality

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7401>

    Some braces / space after switch move brace up line after switch

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7402>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7403>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7404>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7378>

    Use braces in conditional statements.

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7405>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7406>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7407>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7408>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7409>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7410>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7411>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7412>

    Rather put one per line

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7413>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7414>

    No red blocks / Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7415>

    Red Blocks

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7416>

    Red Blocks

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7417>

    Formating / Red Blocks

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7418>

    Red blocks

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7419>

    Red Blocks

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7420>

    Red Blocks

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7421>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7422>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7423>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7424>

    Move Brace after while

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7425>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7426>

    Red blox

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7427>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7428>

    Red Blox

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7429>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7430>

    Braces

/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1096/#comment7431>

    Red Blox

- irroot

On 2011-03-30 10:12:34, romain_proformatique wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1096/
> -----------------------------------------------------------
> 
> (Updated 2011-03-30 10:12:34)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch introduces the skills for queue members, and the ability to route calls by skill rules.
> 
> 
> This addresses bug 0018766.
>     https://issues.asterisk.org/jira/browse/0018766
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 306862 
>   /trunk/configs/queueskillrules.conf.sample PRE-CREATION 
>   /trunk/configs/queueskills.conf.sample PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1096/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> romain_proformatique
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110607/20796cd1/attachment-0001.htm>