[asterisk-dev] [Code Review] fix detection of gcc attributes in menuselect

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1330/#review3944
-----------------------------------------------------------


With -p2, it applies.  However, testing is needed against Fedora to ensure that the test still fails for the CentOS 5.5 gcc 4.1.2 compiler bug.


/trunk/acinclude.m4
<https://reviewboard.asterisk.org/r/1330/#comment7788>

    This specifically mirrors the definition in Asterisk.  If you're going to change it here, you need to change it in Asterisk, as well (and probably first, as that's where the compile will ACTUALLY fail).
    
    The point of the code is to detect a compiler bug shipped with certain releases of CentOS (and Fedora), in order to encode a workaround for that bug.


- Tilghman


On July 27, 2011, 4:53 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1330/
> -----------------------------------------------------------
> 
> (Updated July 27, 2011, 4:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The test for weakref and weak_import attributes is bogus (they are type attributes rather than function attributes). It seems gcc versions before 4.6 somehow let this slip through.
> 
> This patch renames the test name (to reflect the new meaning). In the process it gets rid of unnecessary functionality and adds new one.
> 
> Note that patch includes changes to autoconf. To use, rerun autoconf (or better: autoreconf) after applying.
> 
> 
> Diffs
> -----
> 
>   /trunk/configure.ac 925 
>   /trunk/acinclude.m4 925 
> 
> Diff: https://reviewboard.asterisk.org/r/1330/diff
> 
> 
> Testing
> -------
> 
> Only tested on Linux. Requires testing on OSX and I suspect it will not work as-is there.
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110728/939315d5/attachment.htm>