[asterisk-dev] [Code Review] fix detection of gcc attributes in menuselect

Tzafrir Cohen tzafrir.cohen at xorcom.com
Thu Jul 28 01:57:33 CDT 2011


On Thu, Jul 28, 2011 at 04:55:57AM -0000, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1330/#review3942
> -----------------------------------------------------------
> 
> 
> This patch does not apply against current trunk.  It doesn't even apply against 1.8.  I'm at a complete loss to figure out how you produced the patch, because it does not mesh with 'svn diff' output.

Applies just fine here. Though it requires passing -p2 to patch. I guess
I should have wrote 'trunk' rather than '/trunk' as the branch.

It's based on current svn trunk of menuselect.

(not following-up on the report because my browser crashes when I edit a
comment there. Checking it...)

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir



More information about the asterisk-dev mailing list