[asterisk-dev] [Code Review] IPv6 in Asterisk

[Simon Perreault]

On 07/23/2011 01:51 AM, Paul Belanger wrote:
> /trunk/main/tcptls.c
> <https://reviewboard.asterisk.org/r/743/diff/8/?file=11503#file11503line566>
> (Diff revision 8)
>
> int ast_tls_read_conf(struct ast_tls_config *tls_cfg, struct ast_tcptls_session_args *tls_desc, const char *varname, const char *value)
>
> 563 	
>
> 	}  else  if  (!strcasecmp(varname,  "tlsbindport")  ||  !strcasecmp(varname,  "sslbindport"))  {
>
> 		
>
> 564 	
>
> 		tls_desc->local_address.sin_port  =  htons(atoi(value));
>
> 		
>
> Was this logic removed for a reason?
>
> This creates a regression by removing the'tlsbindport'  /'sslbindport'  options, and affects all people upgrading to Asterisk 1.8+.
>
> If this is expected behavior we need to document in the CHANGES file and remove the setting from our default config files.

Here's the state of things as far as I can tell (considering trunk):

- tlsbindport and sslbindport are no longer supported in the code.
- tldbindport and sslbindport are no longer in the sample sip.conf file.
- The way to set a TLS port is to include it as part of tlsbindaddr.
   e.g. tlsbindaddr=1.2.3.4:1234

For the sake of backward compatibility, we might want to re-add support 
for tlsbindport and sslbindport in the code. Not sure it's a great idea 
though. We merged the port with the address for a reason...

Simon
-- 
DTN made easy, lean, and smart --> http://postellation.viagenie.ca
NAT64/DNS64 open-source        --> http://ecdysis.viagenie.ca
STUN/TURN server               --> http://numb.viagenie.ca