[asterisk-dev] [Code Review] Allow spaces in standard paths and DESTDIR

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1326/#review3909
-----------------------------------------------------------



/branches/1.8/Makefile
<https://reviewboard.asterisk.org/r/1326/#comment7738>

    In my testing on the previous patch, this sort of thing did not work. $(wildcard) assumes that spaces in its arguments separate arguments, and as a result the function does not return the expected results. This needs to be *thoroughly* tested.



/branches/1.8/Makefile
<https://reviewboard.asterisk.org/r/1326/#comment7742>

    Why is this needed?



/branches/1.8/Makefile
<https://reviewboard.asterisk.org/r/1326/#comment7743>

    Is there a POSTINSTALL to clean up these symlinks?



/branches/1.8/Makefile
<https://reviewboard.asterisk.org/r/1326/#comment7739>

    A number of unquoted references to DESTDIR here.


- Kevin


On July 20, 2011, 7:40 p.m., Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1326/
> -----------------------------------------------------------
> 
> (Updated July 20, 2011, 7:40 p.m.)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Kevin Fleming.
> 
> 
> Summary
> -------
> 
> Support for spaces in standard paths was recently reverted, because spaces in DESTDIR were not supported.  This patch implements changes allowing spaces within both standard application paths (standard on Mac OS X), as well as within DESTDIR.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/Makefile 328881 
>   /branches/1.8/Makefile.moddir_rules 328881 
>   /branches/1.8/agi/Makefile 328881 
>   /branches/1.8/configure UNKNOWN 
>   /branches/1.8/configure.ac 328881 
>   /branches/1.8/include/asterisk/autoconfig.h.in 328881 
>   /branches/1.8/makeopts.in 328881 
>   /branches/1.8/sounds/Makefile 328881 
>   /branches/1.8/utils/Makefile 328881 
> 
> Diff: https://reviewboard.asterisk.org/r/1326/diff
> 
> 
> Testing
> -------
> 
> Verified that the install routines run correctly when there are spaces in both standard application paths, as well as in DESTDIR.
> 
> 
> Thanks,
> 
> Tilghman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110721/f528c335/attachment.htm>