[asterisk-dev] [Code Review] Allow spaces in standard paths and DESTDIR

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1326/#review3902
-----------------------------------------------------------



/branches/1.8/configure.ac
<https://reviewboard.asterisk.org/r/1326/#comment7728>

    This may seem like an excessive number of paths, but realize that some paths are encoded as variables within other paths, resolved at installtime.  Since we cannot predict whether a user will define additional dependent paths (especially with an autoconf .spec file), we have to deal with all paths to avoid breakage.



/branches/1.8/sounds/Makefile
<https://reviewboard.asterisk.org/r/1326/#comment7729>

    Note that the reference to DESTDIR has been moved to the makeopts file.


- Tilghman


On July 20, 2011, 7:40 p.m., Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1326/
> -----------------------------------------------------------
> 
> (Updated July 20, 2011, 7:40 p.m.)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Kevin Fleming.
> 
> 
> Summary
> -------
> 
> Support for spaces in standard paths was recently reverted, because spaces in DESTDIR were not supported.  This patch implements changes allowing spaces within both standard application paths (standard on Mac OS X), as well as within DESTDIR.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/Makefile 328881 
>   /branches/1.8/Makefile.moddir_rules 328881 
>   /branches/1.8/agi/Makefile 328881 
>   /branches/1.8/configure UNKNOWN 
>   /branches/1.8/configure.ac 328881 
>   /branches/1.8/include/asterisk/autoconfig.h.in 328881 
>   /branches/1.8/makeopts.in 328881 
>   /branches/1.8/sounds/Makefile 328881 
>   /branches/1.8/utils/Makefile 328881 
> 
> Diff: https://reviewboard.asterisk.org/r/1326/diff
> 
> 
> Testing
> -------
> 
> Verified that the install routines run correctly when there are spaces in both standard application paths, as well as in DESTDIR.
> 
> 
> Thanks,
> 
> Tilghman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110721/256e382b/attachment-0001.htm>