[asterisk-dev] [Code Review] iLBC codec can be added to asterisk again as it is available under a new license now

[one47]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1319/#review3871
-----------------------------------------------------------


I am not a lawyer, BUT... Part of the licence on the Google page is an "Additional IP Rights grant." https://sites.google.com/site/webrtc/license-rights/additional-ip-grant That grant is specifically for "...[Google's] implementation of the WebRTC code package". The source code that this patch adds is not the Google implementation, so you probably do not have full rights to distribute this code with Asterisk.

At the very least I suspect Digium would want to get a lawyer involved before risking it.

- one47


On July 13, 2011, 3:52 p.m., Artem wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1319/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 3:52 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The iLBC codec was acquired by google and released under a new license which is GPL compatible.
> 
> The codec can be inserted in asterisk again.
> 
> The patch adds the iLBC sources, activates the codec by default and removes the contrib script.
> 
> 
> Diffs
> -----
> 
>   /trunk/codecs/codec_ilbc.c 328016 
>   /trunk/codecs/ilbc/FrameClassify.h PRE-CREATION 
>   /trunk/codecs/ilbc/FrameClassify.c PRE-CREATION 
>   /trunk/codecs/ilbc/LICENSE PRE-CREATION 
>   /trunk/codecs/ilbc/LPCdecode.h PRE-CREATION 
>   /trunk/codecs/ilbc/LPCdecode.c PRE-CREATION 
>   /trunk/codecs/ilbc/LPCencode.h PRE-CREATION 
>   /trunk/codecs/ilbc/LPCencode.c PRE-CREATION 
>   /trunk/codecs/ilbc/PATENTS PRE-CREATION 
>   /trunk/codecs/ilbc/StateConstructW.h PRE-CREATION 
>   /trunk/codecs/ilbc/StateConstructW.c PRE-CREATION 
>   /trunk/codecs/ilbc/StateSearchW.h PRE-CREATION 
>   /trunk/codecs/ilbc/StateSearchW.c PRE-CREATION 
>   /trunk/codecs/ilbc/anaFilter.h PRE-CREATION 
>   /trunk/codecs/ilbc/anaFilter.c PRE-CREATION 
>   /trunk/codecs/ilbc/constants.h PRE-CREATION 
>   /trunk/codecs/ilbc/constants.c PRE-CREATION 
>   /trunk/codecs/ilbc/createCB.h PRE-CREATION 
>   /trunk/codecs/ilbc/createCB.c PRE-CREATION 
>   /trunk/codecs/ilbc/doCPLC.h PRE-CREATION 
>   /trunk/codecs/ilbc/doCPLC.c PRE-CREATION 
>   /trunk/codecs/ilbc/enhancer.h PRE-CREATION 
>   /trunk/codecs/ilbc/enhancer.c PRE-CREATION 
>   /trunk/codecs/ilbc/filter.h PRE-CREATION 
>   /trunk/codecs/ilbc/filter.c PRE-CREATION 
>   /trunk/codecs/ilbc/gainquant.h PRE-CREATION 
>   /trunk/codecs/ilbc/gainquant.c PRE-CREATION 
>   /trunk/codecs/ilbc/getCBvec.h PRE-CREATION 
>   /trunk/codecs/ilbc/getCBvec.c PRE-CREATION 
>   /trunk/codecs/ilbc/helpfun.h PRE-CREATION 
>   /trunk/codecs/ilbc/helpfun.c PRE-CREATION 
>   /trunk/codecs/ilbc/hpInput.h PRE-CREATION 
>   /trunk/codecs/ilbc/hpInput.c PRE-CREATION 
>   /trunk/codecs/ilbc/hpOutput.h PRE-CREATION 
>   /trunk/codecs/ilbc/hpOutput.c PRE-CREATION 
>   /trunk/codecs/ilbc/iCBConstruct.h PRE-CREATION 
>   /trunk/codecs/ilbc/iCBConstruct.c PRE-CREATION 
>   /trunk/codecs/ilbc/iCBSearch.h PRE-CREATION 
>   /trunk/codecs/ilbc/iCBSearch.c PRE-CREATION 
>   /trunk/codecs/ilbc/iLBC_decode.h PRE-CREATION 
>   /trunk/codecs/ilbc/iLBC_decode.c PRE-CREATION 
>   /trunk/codecs/ilbc/iLBC_define.h PRE-CREATION 
>   /trunk/codecs/ilbc/iLBC_encode.h PRE-CREATION 
>   /trunk/codecs/ilbc/iLBC_encode.c PRE-CREATION 
>   /trunk/codecs/ilbc/iLBC_test.c PRE-CREATION 
>   /trunk/codecs/ilbc/lsf.h PRE-CREATION 
>   /trunk/codecs/ilbc/lsf.c PRE-CREATION 
>   /trunk/codecs/ilbc/packing.h PRE-CREATION 
>   /trunk/codecs/ilbc/packing.c PRE-CREATION 
>   /trunk/codecs/ilbc/syntFilter.h PRE-CREATION 
>   /trunk/codecs/ilbc/syntFilter.c PRE-CREATION 
>   /trunk/contrib/scripts/get_ilbc_source.sh 328016 
> 
> Diff: https://reviewboard.asterisk.org/r/1319/diff
> 
> 
> Testing
> -------
> 
> Only compilation testing was performed right now. More testing will be done later.
> 
> 
> Thanks,
> 
> Artem
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110714/69a88328/attachment.htm>