<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1319/">https://reviewboard.asterisk.org/r/1319/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not a lawyer, BUT... Part of the licence on the Google page is an "Additional IP Rights grant." https://sites.google.com/site/webrtc/license-rights/additional-ip-grant That grant is specifically for "...[Google's] implementation of the WebRTC code package". The source code that this patch adds is not the Google implementation, so you probably do not have full rights to distribute this code with Asterisk.
At the very least I suspect Digium would want to get a lawyer involved before risking it.</pre>
<br />
<p>- one47</p>
<br />
<p>On July 13th, 2011, 3:52 p.m., Artem wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Artem.</div>
<p style="color: grey;"><i>Updated July 13, 2011, 3:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The iLBC codec was acquired by google and released under a new license which is GPL compatible.
The codec can be inserted in asterisk again.
The patch adds the iLBC sources, activates the codec by default and removes the contrib script.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only compilation testing was performed right now. More testing will be done later.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/codecs/codec_ilbc.c <span style="color: grey">(328016)</span></li>
<li>/trunk/codecs/ilbc/FrameClassify.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/FrameClassify.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/LICENSE <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/LPCdecode.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/LPCdecode.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/LPCencode.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/LPCencode.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/PATENTS <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/StateConstructW.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/StateConstructW.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/StateSearchW.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/StateSearchW.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/anaFilter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/anaFilter.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/constants.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/constants.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/createCB.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/createCB.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/doCPLC.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/doCPLC.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/enhancer.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/enhancer.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/filter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/filter.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/gainquant.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/gainquant.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/getCBvec.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/getCBvec.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/helpfun.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/helpfun.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/hpInput.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/hpInput.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/hpOutput.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/hpOutput.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/iCBConstruct.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/iCBConstruct.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/iCBSearch.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/iCBSearch.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/iLBC_decode.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/iLBC_decode.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/iLBC_define.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/iLBC_encode.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/iLBC_encode.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/iLBC_test.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/lsf.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/lsf.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/packing.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/packing.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/syntFilter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/codecs/ilbc/syntFilter.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/scripts/get_ilbc_source.sh <span style="color: grey">(328016)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1319/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>