[asterisk-dev] [Code Review] inband DTMF cannot be detected and trigger service execute when A and B both use u-law

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1302/#review3859
-----------------------------------------------------------



trunk/main/rtp_engine.c
<https://reviewboard.asterisk.org/r/1302/#comment7678>

    Having a send_digit_begin function only means you have a way to pass DTMF through the bridge, I do not believe it indicates whether or not DTMF will be received on a channel or not.
    
    Like my last comment, checking to see if ast_rtp_instance_dtmf_mode_get() is set to none or not should tell you if DTMF is coming over rtp.


- David


On July 11, 2011, 3:49 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1302/
> -----------------------------------------------------------
> 
> (Updated July 11, 2011, 3:49 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When deciding whether Asterisk was allowed to bridge the call away from the core, chan_sip did not take into account the usage of features on dialed channels that require monitoring of DTMF on channels utilizing inband DTMF.  This would cause Asterisk to allow the call to be locally or remotely bridged, preventing access to the data required to detect activations of such features.  chan_sip now checks this and disallows bridging away from the core when using inband DTMF and certain dialed features simultaneously.
> 
> 
> This addresses bug ASTERISK-17237.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17237
> 
> 
> Diffs
> -----
> 
>   trunk/main/rtp_engine.c 325090 
> 
> Diff: https://reviewboard.asterisk.org/r/1302/diff
> 
> 
> Testing
> -------
> 
> The scenario described in the bug report now works as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110712/777c3142/attachment-0001.htm>