[asterisk-dev] [Code Review] inband DTMF cannot be detected and trigger service execute when A and B both use u-law

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1302/
-----------------------------------------------------------

(Updated July 11, 2011, 3:49 p.m.)


Review request for Asterisk Developers.


Changes
-------

As per ast_rtp_dtmf_compatible, the existence of send_digit_begin on the channel tech can be used to determine whether the DTMF is carried outside the RTP stream.


Summary
-------

When deciding whether Asterisk was allowed to bridge the call away from the core, chan_sip did not take into account the usage of features on dialed channels that require monitoring of DTMF on channels utilizing inband DTMF.  This would cause Asterisk to allow the call to be locally or remotely bridged, preventing access to the data required to detect activations of such features.  chan_sip now checks this and disallows bridging away from the core when using inband DTMF and certain dialed features simultaneously.


This addresses bug ASTERISK-17237.
    https://issues.asterisk.org/jira/browse/ASTERISK-17237


Diffs (updated)
-----

  trunk/main/rtp_engine.c 325090 

Diff: https://reviewboard.asterisk.org/r/1302/diff


Testing
-------

The scenario described in the bug report now works as expected.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110711/b49968be/attachment-0001.htm>