[asterisk-dev] [Code Review] app_queue log membername when state_interface is set for ADDMEMBER and REMOVEMEMBER events.

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1286/#review3802
-----------------------------------------------------------


This is looking good few minor changes ... this has caused me some problems and elborate SQL has worked arround it.

good job think its almost there.

Greg


http://svn.asterisk.org/svn/asterisk/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1286/#comment7610>

    rather match this to the option in queues.conf to maintain consistancy.



http://svn.asterisk.org/svn/asterisk/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1286/#comment7606>

    This should probably be a new function as you repeat it bellow twice rather put repetitive blocks into a function.
    
    it would be better to use load_realtime_queue(name) to find the queue as there is no guarantee the queue you looking for is loaded into memory.
    
    
    



http://svn.asterisk.org/svn/asterisk/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1286/#comment7611>

    keep the name and variable consistent see above also maintain the convention of _ not -.



http://svn.asterisk.org/svn/asterisk/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1286/#comment7607>

    See Above.



http://svn.asterisk.org/svn/asterisk/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1286/#comment7609>

    Someone took a kid to the office and gave them a red marker.



http://svn.asterisk.org/svn/asterisk/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1286/#comment7608>

    See Above.



http://svn.asterisk.org/svn/asterisk/trunk/configs/queues.conf.sample
<https://reviewboard.asterisk.org/r/1286/#comment7612>

    maintain naming / variable / separator consistency. 


- irroot


On July 3, 2011, 5:18 a.m., jamuel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1286/
> -----------------------------------------------------------
> 
> (Updated July 3, 2011, 5:18 a.m.)
> 
> 
> Review request for Asterisk Developers, Tilghman Lesher, leifmadsen, and opticron.
> 
> 
> Summary
> -------
> 
> app_queue logs the events ADDMEMBER and REMOVEMEMBER with the agent field set to the interface value rather than the membername value when a member is added with a state_interface value set.  However all other member related queue events are logged with the membername when a state_interface is set. It would seem that these ADD/REMOVE MEMBER events should log the agent field in the same manner. 
> 
> This patch addresses the original issue reported in https://issues.asterisk.org/jira/browse/ASTERISK-14769 by providing a queues.conf general configuration option log-member-as-agent. Setting log-member-as-agent = yes will cause the membername to be logged in the agent field for ADDMEMBER and REMOVEMEMBER queue events if a state_interface has been set.
> 
> The default value (log-member-as-agent = no) does not alter the existing logging for the ADDMEMBER and REMOVEMEMBER events to maintain existing (buggy) behavior for the sake of backwards compatibility. 
> 
> 
> This addresses bug https://issues.asterisk.org/jira/browse/ASTERISK-14769.
>     https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-14769
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/trunk/apps/app_queue.c 326143 
>   http://svn.asterisk.org/svn/asterisk/trunk/configs/queues.conf.sample 326143 
> 
> Diff: https://reviewboard.asterisk.org/r/1286/diff
> 
> 
> Testing
> -------
> 
> Tested add, remove, pause, unpause via AMI and CLI and see the correct log output to queue_log.  Also tested with log-member-as-agent omitted to insure backward compatibility for those queues.conf that might not be updated for this new option. 
> 
> 
> Thanks,
> 
> jamuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110703/19d1e27c/attachment-0001.htm>