[asterisk-dev] [Code Review] app_queue log membername when state_interface is set for ADDMEMBER and REMOVEMEMBER events.

[jamuel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1286/
-----------------------------------------------------------

(Updated July 3, 2011, 5:18 a.m.)


Review request for Asterisk Developers, Tilghman Lesher, leifmadsen, and opticron.


Changes
-------

Improved formatting (to get rid of red blobs).


Summary
-------

app_queue logs the events ADDMEMBER and REMOVEMEMBER with the agent field set to the interface value rather than the membername value when a member is added with a state_interface value set.  However all other member related queue events are logged with the membername when a state_interface is set. It would seem that these ADD/REMOVE MEMBER events should log the agent field in the same manner. 

This patch addresses the original issue reported in https://issues.asterisk.org/jira/browse/ASTERISK-14769 by providing a queues.conf general configuration option log-member-as-agent. Setting log-member-as-agent = yes will cause the membername to be logged in the agent field for ADDMEMBER and REMOVEMEMBER queue events if a state_interface has been set.

The default value (log-member-as-agent = no) does not alter the existing logging for the ADDMEMBER and REMOVEMEMBER events to maintain existing (buggy) behavior for the sake of backwards compatibility. 


This addresses bug https://issues.asterisk.org/jira/browse/ASTERISK-14769.
    https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-14769


Diffs (updated)
-----

  http://svn.asterisk.org/svn/asterisk/trunk/apps/app_queue.c 326143 
  http://svn.asterisk.org/svn/asterisk/trunk/configs/queues.conf.sample 326143 

Diff: https://reviewboard.asterisk.org/r/1286/diff


Testing
-------

Tested add, remove, pause, unpause via AMI and CLI and see the correct log output to queue_log.  Also tested with log-member-as-agent omitted to insure backward compatibility for those queues.conf that might not be updated for this new option. 


Thanks,

jamuel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110703/6ab455d1/attachment.htm>