[asterisk-dev] [Code Review] ConfBridge User Announce Feature Set

[Andrew Parisio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1011/
-----------------------------------------------------------

(Updated 2011-01-10 16:41:56.831818)


Review request for Asterisk Developers.


Changes
-------

Changes made, I searched the entire diff and fixed all of the other comma spacing issues as well.  How does it look now?

Thanks!


Summary
-------

I copied the i and I features from meetme, as well as the same h functionality I posted in reviewboard 1009.  

I noticed I could cause a segfault if I called in from extension 1, then called in from extensions 2 and 3 at the exact same time but they had to be almost identically timed.  This didn't seem to happen in the trunk version so I think it's part of this patch.  I'm not sure if it's related to one of the locks on the bridge but I'm hoping somebody that is more knowledgeable about ConfBridge may be able to help there.


Diffs (updated)
-----

  /trunk/apps/app_confbridge.c 299310 

Diff: https://reviewboard.asterisk.org/r/1011/diff


Testing
-------

ConfBridge(1,i)
ConfBridge(1,I)
ConfBridge(1,h(1593 at default))


Thanks,

Andrew

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110110/1e18c165/attachment.htm>