[asterisk-dev] [Code Review] [Regression] asterisk 1.6.2 / 1.8 tarball sound files ignored, Makefile re-downloads them.

[pprindeville]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1074/#review3084
-----------------------------------------------------------


Looks good to me.

- pprindeville


On 2011-01-08 20:33:36, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1074/
> -----------------------------------------------------------
> 
> (Updated 2011-01-08 20:33:36)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> While working on debian packages for Asterisk 1.8, I notice the sound files included within the asterisk-1.8.1.1.tar.gz we not being detected and the Makefile was downloading them again.
> 
> The attach patch fixes the issue by default asterisk SOUND_CACHE_DIR to empty, rather then ${HOME}/.asterisk_sounds_cache.  Users wanting to cache the file can still override the setting at build time.
> 
> 
> This addresses bug 18589.
>     https://issues.asterisk.org/view.php?id=18589
> 
> 
> Diffs
> -----
> 
>   branches/1.6.2/autoconf/ast_ext_lib.m4 299311 
>   branches/1.6.2/configure.ac 299311 
> 
> Diff: https://reviewboard.asterisk.org/r/1074/diff
> 
> 
> Testing
> -------
> 
> downloaded asterisk-1.8.1.1.tar.gz, applied patch, sound files detected properly (not re-downloaded).
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110109/0a7e90bc/attachment.htm>