[asterisk-dev] [Code Review] [Regression] asterisk 1.6.2 / 1.8 tarball sound files ignored, Makefile re-downloads them.

Paul Belanger reviewboard at asterisk.org
Sun Jan 9 02:33:36 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1074/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

While working on debian packages for Asterisk 1.8, I notice the sound files included within the asterisk-1.8.1.1.tar.gz we not being detected and the Makefile was downloading them again.

The attach patch fixes the issue by default asterisk SOUND_CACHE_DIR to empty, rather then ${HOME}/.asterisk_sounds_cache.  Users wanting to cache the file can still override the setting at build time.


This addresses bug 18589.
    https://issues.asterisk.org/view.php?id=18589


Diffs
-----

  branches/1.6.2/autoconf/ast_ext_lib.m4 299311 
  branches/1.6.2/configure.ac 299311 

Diff: https://reviewboard.asterisk.org/r/1074/diff


Testing
-------

downloaded asterisk-1.8.1.1.tar.gz, applied patch, sound files detected properly (not re-downloaded).


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110109/953e5c67/attachment.htm>


More information about the asterisk-dev mailing list