[asterisk-dev] [Code Review] ConfBridge User Announce Feature Set

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1011/#review3081
-----------------------------------------------------------



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6327>

    space between ){



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6326>

    Invert your logic, large code blocks should be first.



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6328>

    spacing after commas



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6329>

    same comment, spacing.  Move { up to the same line as the if statement



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6330>

    spacing



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6331>

    same



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6332>

    ast_debug()



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6333>

    { } for if statements



/trunk/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/1011/#comment6334>

    space between ){


- Paul


On 2010-11-29 12:55:37, Andrew Parisio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1011/
> -----------------------------------------------------------
> 
> (Updated 2010-11-29 12:55:37)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I copied the i and I features from meetme, as well as the same h functionality I posted in reviewboard 1009.  
> 
> I noticed I could cause a segfault if I called in from extension 1, then called in from extensions 2 and 3 at the exact same time but they had to be almost identically timed.  This didn't seem to happen in the trunk version so I think it's part of this patch.  I'm not sure if it's related to one of the locks on the bridge but I'm hoping somebody that is more knowledgeable about ConfBridge may be able to help there.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_confbridge.c 294568 
> 
> Diff: https://reviewboard.asterisk.org/r/1011/diff
> 
> 
> Testing
> -------
> 
> ConfBridge(1,i)
> ConfBridge(1,I)
> ConfBridge(1,h(1593 at default))
> 
> 
> Thanks,
> 
> Andrew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110106/d9f87084/attachment-0001.htm>