[asterisk-dev] [dahdi-commits] sruffell: linux/trunk r9597 - /linux/trunk/drivers/dahdi/

[Shaun Ruffell]

On 01/04/2011 01:07 PM, Kevin P. Fleming wrote:
> On 01/03/2011 12:27 PM, SVN commits to the DAHDI project wrote:
>> Author: sruffell
>> Date: Mon Jan  3 12:27:23 2011
>> New Revision: 9597
>>
>> URL: http://svnview.digium.com/svn/dahdi?view=rev&rev=9597
>> Log:
>> dahdi: Move the contents of digits.h directly into dahdi-base.c
>>
>> Clarify that these definitions are not / no longer used outside
>> dahdi-base.c.
> 
> I'm not sure this is a good idea; before, there was a very logical place
> for a user to change these defaults if they so desired, and if they had
> a patch they would apply for that purpose, it would be fairly stable
> since the file being patched rarely ever sees changes. Now they'll have
> to create a patch against dahdi-base.c, and keep it updated.
> 
> These constants were not in a header file because they were shared among
> multiple code files, they were there for the convenience of users who
> may want to change the

That's a point I had not considered.  So unless someone else speaks up,
I'll move those defaults into include/dahdi/dahdi_config.h like we
discussed on #asterisk-dev.

Thanks,
Shaun

-- 
Shaun Ruffell
Digium, Inc. | Linux Kernel Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: www.digium.com & www.asterisk.org