[asterisk-dev] [Code Review] Properly route responses according to the Via headers in the request

Matthew Nicholson reviewboard at asterisk.org
Tue Jan 4 14:30:15 CST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated 2011-01-04 14:30:15.023440)

Review request for Asterisk Developers.


This version of the patch splits via parsing into it's own function.  Also, now ttl is handled with maddr.  I am not sure if this is the proper way to handle the ttl value and I did not test with packets containing maddr and/or ttl.


This patch makes asterisk respect the Via headers in a request when responding to the request. Without this patch, the request is always routed back to the address the initial request was received from (unless nat=yes).  This can cause problems if the initial request comes through a proxy and additional requests (such as INFO dtmf tones) come from a different proxy.

Diffs (updated)

  /branches/1.4/channels/chan_sip.c 300373 

Diff: https://reviewboard.asterisk.org/r/1059/diff


Briefly tested using openser as a proxy and another asterisk machine as the requester.  I sent and invite, then some INFO DTMF messages.  Without the patch, our asterisk machine sends all responses to the INFO requests to the proxy, with the patch they are properly routed to the requesting asterisk machine.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110104/183490bd/attachment-0001.htm>

More information about the asterisk-dev mailing list