[asterisk-dev] [Code Review] Announce to user that they have been muted when muting is done via AMI

kobaz reviewboard at asterisk.org
Thu Feb 10 15:02:14 CST 2011



> On 2011-02-10 14:31:17, Paul Belanger wrote:
> > trunk/apps/app_meetme.c, line 4868
> > <https://reviewboard.asterisk.org/r/1010/diff/4/?file=15470#file15470line4868>
> >
> >     Would be good to document this some place, for now the wiki.

What documentation would be needed?  This is a bug fix.  The comment says it all: The not talking detection doesn't kick in if the user was talking while being muted.  Perhaps a separate issue should be filed?  


- kobaz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1010/#review3177
-----------------------------------------------------------


On 2011-02-10 13:08:01, kobaz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1010/
> -----------------------------------------------------------
> 
> (Updated 2011-02-10 13:08:01)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Announce to user that they have been muted when muting is done via AMI
> 
> When a user does a *1, they hear 'you have been (un)muted'
> When a mute or unmute command is sent over the ami, the user hears no mute notification.
> 
> I'm not sure if my method of handling stopping/resuming music on hold is correct.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_meetme.c 307508 
> 
> Diff: https://reviewboard.asterisk.org/r/1010/diff
> 
> 
> Testing
> -------
> 
> AMI MeetmeMute
> AMI MeetmeUnmute
> 
> 
> Thanks,
> 
> kobaz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110210/5a0dfecf/attachment.htm>


More information about the asterisk-dev mailing list