[asterisk-dev] [Code Review] Allow overriding of IMAP server settings on a user by user basis

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1614/#review5079
-----------------------------------------------------------


Everything looks to be in order.  The non-IMAP copy function caught me off guard since it passes a null vms to the file store routine, but of course that doesn't apply to IMAP storage.

- opticron


On Dec. 8, 2011, 10:15 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1614/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2011, 10:15 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch allows the imapserver, imapport, and imapflags settings to be overridden for any voicemail user.
> 
> Note that the original patch in ASTERISK-16489 only allowed for overriding imapserver; however, that wouldn't have been terribly useful if, given two IMAP servers, any of the other server settings were different.
> 
> 
> This addresses bug ASTERISK-16489.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16489
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/voicemail.conf.sample 347345 
>   /trunk/apps/app_voicemail.c 347345 
>   /trunk/CHANGES 347345 
>   /trunk/contrib/realtime/mysql/voicemail.sql 347345 
> 
> Diff: https://reviewboard.asterisk.org/r/1614/diff
> 
> 
> Testing
> -------
> 
> Tested using integration with a gmail IMAP server / mailbox.  The global settings were all set to 'dummy' values (localhost, etc.) while the actual connection settings were specified for a voicemail user.  Tested leaving a voicemail, playing back the voicemail, deleting, etc.  Standard IMAP integration behavior was observed using the settings obtained from the voicemail user.
> 
> Compiled with the TEST_FRAMEWORK flag (which requires fixing a warning in the UW IMAP library).  Tested the vm_user unit test, which was modified to override the new IMAP settings.  Test passed.  Note that several other unit tests specific to app_voicemail don't pass, as they don't support IMAP.
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111223/6e0ef792/attachment.htm>