[asterisk-dev] [Code Review] Initial ConfBridge test

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1636/#review5063
-----------------------------------------------------------



/asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast1/confbridge.conf
<https://reviewboard.asterisk.org/r/1636/#comment9329>

    Yeah, it lined up better in my text editor.  I'll just change it to spaces.



/asterisk/trunk/tests/apps/confbridge/confbridge_nominal/run-test
<https://reviewboard.asterisk.org/r/1636/#comment9330>

    Actually, the state machine is a set of classes.  As test notifications are sent out from Asterisk, the "handleStateChange" (indicating a change in application state happened in Asterisk) is handled in this function, which is an override of a base class.  Each class can choose to "change the state" by changing the class that the controller will send notifications to.
    
    That being said, ConfBridge makes it difficult.  There are three users logging into ConfBridge at the same time, and there's no way to know how long it will take to log in each of the three users - plus, their updates are coming interleaved with each other.  The best I could come up with was to change the class that the controller points to once everyone has gotten themselves inside the ConfBridge - any other time, and you'd have 'log in' related actions in multiple classes, which would defeat the purpose.
    
    This is ugly however.  I could break it up into separate handler methods within this class which would make it a bit more reasonable - so I'll do that and see if it helps readability.


- Matt


On Dec. 21, 2011, 3:16 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1636/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, 3:16 p.m.)
> 
> 
> Review request for Asterisk Developers, David Vossel, Paul Belanger, and jrose.
> 
> 
> Summary
> -------
> 
> This adds a test to cover the nominal execution of the ConfBridge application in Asterisk 10.  It includes:
> 1. Multiple user profiles / DTMF menus
> 2. Use of pins, recording of names, and playback of notifications within the conference
> 3. Checking that user profile options are applied
> 
> Note that this uses the TestEvent AMI event to keep track of what occurs during ConfBridge execution.  Several event notifications have been added to ConfBridge in order to have this test work.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast1/confbridge.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/sounds/talking.ulaw PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/tests.yaml 2921 
> 
> Diff: https://reviewboard.asterisk.org/r/1636/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111222/6c617a04/attachment.htm>