[asterisk-dev] [Code Review] Initial ConfBridge test

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1636/#review5058
-----------------------------------------------------------

Ship it!


It looks like it does what you set out to do. It basically reminds me of that one voicemail test with the new user creation in terms of method.


/asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast1/confbridge.conf
<https://reviewboard.asterisk.org/r/1636/#comment9322>

    Not sure if this matters at all, but you've got some pretty nasty looking tabs here.



/asterisk/trunk/tests/apps/confbridge/confbridge_nominal/run-test
<https://reviewboard.asterisk.org/r/1636/#comment9323>

    This function looks a little like a rat king, and it's mostly because of this state machine starting here. I feel like this could be a lot more immediately understandable if the state machine was moved to a dedicated function.


- jrose


On Dec. 21, 2011, 3:16 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1636/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, 3:16 p.m.)
> 
> 
> Review request for Asterisk Developers, David Vossel, Paul Belanger, and jrose.
> 
> 
> Summary
> -------
> 
> This adds a test to cover the nominal execution of the ConfBridge application in Asterisk 10.  It includes:
> 1. Multiple user profiles / DTMF menus
> 2. Use of pins, recording of names, and playback of notifications within the conference
> 3. Checking that user profile options are applied
> 
> Note that this uses the TestEvent AMI event to keep track of what occurs during ConfBridge execution.  Several event notifications have been added to ConfBridge in order to have this test work.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast1/confbridge.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/configs/ast2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_nominal/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/sounds/talking.ulaw PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/tests.yaml 2921 
> 
> Diff: https://reviewboard.asterisk.org/r/1636/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111222/f1a46b84/attachment.htm>