[asterisk-dev] [Code Review]: Queue Tests: Queue Set Penalty command and QueuePenalty ami action.

[jrose]

> On Dec. 14, 2011, 4:25 p.m., Matt Jordan wrote:
> > /asterisk/trunk/tests/queues/set_penalty/run-test, line 85
> > <https://reviewboard.asterisk.org/r/1611/diff/2/?file=22173#file22173line85>
> >
> >     And one more

Got all four of them.


> On Dec. 14, 2011, 4:25 p.m., Matt Jordan wrote:
> > /asterisk/trunk/tests/queues/set_penalty/test-config.yaml, line 12
> > <https://reviewboard.asterisk.org/r/1611/diff/2/?file=22174#file22174line12>
> >
> >     Go ahead and put a dependency on app_queue here.  Seems obvious, but if someone runs this on their system with noload=>app_queue in their modules.conf, this will prevent it from doing bad things

Would it be worth adding this for the existing queue tests as well?


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1611/#review5011
-----------------------------------------------------------


On Dec. 9, 2011, 11:46 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1611/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2011, 11:46 a.m.)
> 
> 
> Review request for Asterisk Developers, Paul Belanger and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This test will attempt to do a few a few queue penalty changing operations, including those addressed in https://reviewboard.asterisk.org/r/1609/
> 
> This test has been made in a way such that adding extra related subtests should be a fairly trivial matter.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/queues/set_penalty/configs/ast1/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/tests.yaml 2868 
> 
> Diff: https://reviewboard.asterisk.org/r/1611/diff
> 
> 
> Testing
> -------
> 
> Ran the test, tweaked the test to see that the success condition flags work properly.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111215/48488035/attachment.htm>