[asterisk-dev] [Code Review] Queue Tests: Queue Set Penalty command and QueuePenalty ami action.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1611/#review5011
-----------------------------------------------------------



/asterisk/trunk/tests/queues/set_penalty/run-test
<https://reviewboard.asterisk.org/r/1611/#comment9263>

    If you don't get the expected result, kill the test here.  Since you'll never advance to the next state, the test will timeout - but there's no need to wait 30 seconds, since you know you've failed



/asterisk/trunk/tests/queues/set_penalty/run-test
<https://reviewboard.asterisk.org/r/1611/#comment9264>

    Same here - in particular, if you don't stop the test on an unexpected input here then you could receive a valid input (say "queue1"), receive an invalid input (say, not "queue2"), and never kill the test.



/asterisk/trunk/tests/queues/set_penalty/run-test
<https://reviewboard.asterisk.org/r/1611/#comment9265>

    And one more



/asterisk/trunk/tests/queues/set_penalty/test-config.yaml
<https://reviewboard.asterisk.org/r/1611/#comment9266>

    Go ahead and put a dependency on app_queue here.  Seems obvious, but if someone runs this on their system with noload=>app_queue in their modules.conf, this will prevent it from doing bad things


- Matt


On Dec. 9, 2011, 11:46 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1611/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2011, 11:46 a.m.)
> 
> 
> Review request for Asterisk Developers, Paul Belanger and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This test will attempt to do a few a few queue penalty changing operations, including those addressed in https://reviewboard.asterisk.org/r/1609/
> 
> This test has been made in a way such that adding extra related subtests should be a fairly trivial matter.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/queues/set_penalty/configs/ast1/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/tests.yaml 2868 
> 
> Diff: https://reviewboard.asterisk.org/r/1611/diff
> 
> 
> Testing
> -------
> 
> Ran the test, tweaked the test to see that the success condition flags work properly.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111214/5be55b2b/attachment.htm>