[asterisk-dev] [Code Review] Fix FollowMe CallerID on outgoing calls.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1612/#review5004
-----------------------------------------------------------

Ship it!


Looks good

- Matt


On Dec. 9, 2011, 3:09 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1612/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2011, 3:09 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The addition of the Connected Line support changed how CallerID is passed to outgoing calls.  The FollowMe application was not updated to pass CallerID to the outgoing calls.
> 
> * Fix FollowMe CallerID on outgoing calls.
> * Restructured findmeexec() to fix several memory leaks and eliminate some duplicated code.
> * Made check the return value of create_followme_number().  Putting a NULL into the numbers list is bad if create_followme_number() fails.
> * Fixed a couple uses of ast_strdupa() inside loops.
> 
> The changes to bridge_builtin_features.c fix a similar CallerID issue with the bridging API attended and blind transfers.
> 
> 
> This addresses bug ASTERISK-17557.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17557
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_followme.c 347865 
>   /branches/1.8/bridges/bridge_builtin_features.c 347865 
> 
> Diff: https://reviewboard.asterisk.org/r/1612/diff
> 
> 
> Testing
> -------
> 
> FollowMe now supplies the CallerID on outgoing calls.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111213/989763d7/attachment.htm>