[asterisk-dev] [Code Review] Fix FollowMe CallerID on outgoing calls.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1612/#review4984
-----------------------------------------------------------



/branches/1.8/apps/app_followme.c
<https://reviewboard.asterisk.org/r/1612/#comment9240>

    Removed the need for timeoutstr by moving some code around.



/branches/1.8/apps/app_followme.c
<https://reviewboard.asterisk.org/r/1612/#comment9241>

    We would have corrupted the numbers list before and likely crashed later.



/branches/1.8/apps/app_followme.c
<https://reviewboard.asterisk.org/r/1612/#comment9242>

    We used to bail and leak memory as well as abandon any earlier calls already initiated.  If this alloc fails now, the call is simply not placed and any necessary cleanup is performed.



/branches/1.8/apps/app_followme.c
<https://reviewboard.asterisk.org/r/1612/#comment9243>

    Cannot do that.  If the outbound call succeeds then tmpuser cannot be freed because it is put in a list.
    
    I could invert tests to reduce the indentation level, but that would just make the diff harder to follow.



/branches/1.8/apps/app_followme.c
<https://reviewboard.asterisk.org/r/1612/#comment9244>

    See earlier. :)


- rmudgett


On Dec. 6, 2011, 4:11 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1612/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2011, 4:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The addition of the Connected Line support changed how CallerID is passed to outgoing calls.  The FollowMe application was not updated to pass CallerID to the outgoing calls.
> 
> * Fix FollowMe CallerID on outgoing calls.
> * Restructured findmeexec() to fix several memory leaks and eliminate some duplicated code.
> * Made check the return value of create_followme_number().  Putting a NULL into the numbers list is bad if create_followme_number() fails.
> * Fixed a couple uses of ast_strdupa() inside loops.
> 
> The changes to bridge_builtin_features.c fix a similar CallerID issue with the bridging API attended and blind transfers.
> 
> 
> This addresses bug ASTERISK-17557.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17557
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_followme.c 347238 
>   /branches/1.8/bridges/bridge_builtin_features.c 347238 
> 
> Diff: https://reviewboard.asterisk.org/r/1612/diff
> 
> 
> Testing
> -------
> 
> FollowMe now supplies the CallerID on outgoing calls.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111209/87e49754/attachment.htm>