[asterisk-dev] [Code Review] Fix FollowMe CallerID on outgoing calls.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1612/#review4980
-----------------------------------------------------------



/branches/1.8/apps/app_followme.c
<https://reviewboard.asterisk.org/r/1612/#comment9235>

    If we don't need to duplicate the temporary string, then is there any need for timeoutstr in the first place?



/branches/1.8/apps/app_followme.c
<https://reviewboard.asterisk.org/r/1612/#comment9236>

    If we fail to create the followme number here (which should be due to a memory allocation failure), we probably should fail the reload



/branches/1.8/apps/app_followme.c
<https://reviewboard.asterisk.org/r/1612/#comment9237>

    I'm not sure we should continue here if we fail to allocate the tmpuser.  Things are likely to continue to go horribly wrong if an alloc fails.



/branches/1.8/apps/app_followme.c
<https://reviewboard.asterisk.org/r/1612/#comment9238>

    Since tmpuser is allocated outside of the if (outbound) check, my personal preference would be to see it free'd outside of the if block as well



/branches/1.8/apps/app_followme.c
<https://reviewboard.asterisk.org/r/1612/#comment9239>

    Again, if this fails to create a followme number, should we bail?


- Matt


On Dec. 6, 2011, 4:11 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1612/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2011, 4:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The addition of the Connected Line support changed how CallerID is passed to outgoing calls.  The FollowMe application was not updated to pass CallerID to the outgoing calls.
> 
> * Fix FollowMe CallerID on outgoing calls.
> * Restructured findmeexec() to fix several memory leaks and eliminate some duplicated code.
> * Made check the return value of create_followme_number().  Putting a NULL into the numbers list is bad if create_followme_number() fails.
> * Fixed a couple uses of ast_strdupa() inside loops.
> 
> The changes to bridge_builtin_features.c fix a similar CallerID issue with the bridging API attended and blind transfers.
> 
> 
> This addresses bug ASTERISK-17557.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17557
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_followme.c 347238 
>   /branches/1.8/bridges/bridge_builtin_features.c 347238 
> 
> Diff: https://reviewboard.asterisk.org/r/1612/diff
> 
> 
> Testing
> -------
> 
> FollowMe now supplies the CallerID on outgoing calls.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111209/3296c6ca/attachment.htm>