[asterisk-dev] [Code Review]: Queue Tests: Queue Set Penalty command and QueuePenalty ami action.

[jrose]

> On Dec. 9, 2011, 11:16 a.m., Paul Belanger wrote:
> > /asterisk/trunk/tests/queues/set_penalty/configs/ast1/sip.conf, line 1
> > <https://reviewboard.asterisk.org/r/1611/diff/1/?file=22121#file22121line1>
> >
> >     binaddr=127.0.0.1

Alright, got it.


> On Dec. 9, 2011, 11:16 a.m., Paul Belanger wrote:
> > /asterisk/trunk/tests/queues/set_penalty/run-test, line 36
> > <https://reviewboard.asterisk.org/r/1611/diff/1/?file=22122#file22122line36>
> >
> >     You should be overloading the super().
> >     
> >     I've noticed this a few times for people, perhaps we should make the testsuite automatically do it.

You mean this number?  *shouldn't be overriding the super?
def ami_connect(self, ami):
TestCase.ami_connect(self, ami)
or
super.ami-connect(self, ami)

In that case, yeah, that was an oversight on my part this time.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1611/#review4977
-----------------------------------------------------------


On Dec. 9, 2011, 9:15 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1611/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2011, 9:15 a.m.)
> 
> 
> Review request for Asterisk Developers, Paul Belanger and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This test will attempt to do a few a few queue penalty changing operations, including those addressed in https://reviewboard.asterisk.org/r/1609/
> 
> This test has been made in a way such that adding extra related subtests should be a fairly trivial matter.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/queues/set_penalty/configs/ast1/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/tests.yaml 2868 
> 
> Diff: https://reviewboard.asterisk.org/r/1611/diff
> 
> 
> Testing
> -------
> 
> Ran the test, tweaked the test to see that the success condition flags work properly.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111209/ef067d8e/attachment-0001.htm>