[asterisk-dev] [Code Review] Queue Tests: Queue Set Penalty command and QueuePenalty ami action.

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1611/#review4977
-----------------------------------------------------------



/asterisk/trunk/tests/queues/set_penalty/configs/ast1/sip.conf
<https://reviewboard.asterisk.org/r/1611/#comment9231>

    binaddr=127.0.0.1



/asterisk/trunk/tests/queues/set_penalty/run-test
<https://reviewboard.asterisk.org/r/1611/#comment9230>

    You should be overloading the super().
    
    I've noticed this a few times for people, perhaps we should make the testsuite automatically do it.  


- Paul


On Dec. 9, 2011, 9:15 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1611/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2011, 9:15 a.m.)
> 
> 
> Review request for Asterisk Developers, Paul Belanger and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This test will attempt to do a few a few queue penalty changing operations, including those addressed in https://reviewboard.asterisk.org/r/1609/
> 
> This test has been made in a way such that adding extra related subtests should be a fairly trivial matter.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/queues/set_penalty/configs/ast1/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/set_penalty/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/tests.yaml 2868 
> 
> Diff: https://reviewboard.asterisk.org/r/1611/diff
> 
> 
> Testing
> -------
> 
> Ran the test, tweaked the test to see that the success condition flags work properly.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111209/be6faae4/attachment.htm>