[asterisk-dev] [Code Review] Don't sleep waiting for fullybooted

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1616/#review4976
-----------------------------------------------------------

Ship it!


+1 for faster tests

- Paul


On Dec. 9, 2011, 11 a.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1616/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2011, 11 a.m.)
> 
> 
> Review request for Asterisk Developers, Paul Belanger and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Instead of sleeping 5 seconds (when in actuality it almost always takes significantly under 1 second) before issuing the cli_exec for checking fullybooted status, loop while asterisk -rx returns non-zero (up to 5 seconds). Saving over 4 seconds/test could save 5-10 minutes when running all of the tests.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 2869 
> 
> Diff: https://reviewboard.asterisk.org/r/1616/diff
> 
> 
> Testing
> -------
> 
> Ran a test, noticed that it ran almost 5 seconds faster. I haven't tested the failure scenario with the code itself, but mocked something up with the python REPL that seemed to work.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111209/bac33478/attachment.htm>