[asterisk-dev] [Code Review] Don't sleep waiting for fullybooted

Terry Wilson reviewboard at asterisk.org
Fri Dec 9 11:00:58 CST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers, Paul Belanger and Matt Jordan.


Instead of sleeping 5 seconds (when in actuality it almost always takes significantly under 1 second) before issuing the cli_exec for checking fullybooted status, loop while asterisk -rx returns non-zero (up to 5 seconds). Saving over 4 seconds/test could save 5-10 minutes when running all of the tests.


  /asterisk/trunk/lib/python/asterisk/asterisk.py 2869 

Diff: https://reviewboard.asterisk.org/r/1616/diff


Ran a test, noticed that it ran almost 5 seconds faster. I haven't tested the failure scenario with the code itself, but mocked something up with the python REPL that seemed to work.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111209/3d9064fc/attachment.htm>

More information about the asterisk-dev mailing list