[asterisk-dev] [Code Review] Add manager event for early media

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1187/#review4968
-----------------------------------------------------------



/team/oej/bring-in-the-early-media-trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/1187/#comment9224>

    I'm somewhat confused about this chunk.  Why are we sending an AMI event from here when none of the other pbx_builtin_ functions do?  This includes answer, progressing, ringing, etc.
    
    Other than that though, this patch looks fine.  I've already tested it and so if you can just explain this bit to me, I'll give it a thumbs up.


- jrose


On Sept. 19, 2011, 6:43 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1187/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 6:43 a.m.)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> Add a manager event for early media. Using the existing Newstate event with a "faked" state called "progress". 
> 
> In the long run, this is not the right thing to do, but after discussion with Russell on asterisk-dev it was concluded that it was the easiest way forward.
> 
> 
> This addresses bug 19135.
>     https://issues.asterisk.org/jira/browse/19135
> 
> 
> Diffs
> -----
> 
>   /team/oej/bring-in-the-early-media-trunk/apps/app_dial.c 332755 
>   /team/oej/bring-in-the-early-media-trunk/main/pbx.c 332755 
> 
> Diff: https://reviewboard.asterisk.org/r/1187/diff
> 
> 
> Testing
> -------
> 
> Tested many calls in the 1.4 version of the same patch. 
> 
> One-legged calls using the progress() dialplan app, two legged calls using dial().
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111208/33ff3c67/attachment-0001.htm>