[asterisk-dev] [Code Review] regression: tls test failed after my tcpenable fix

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1615/#review4966
-----------------------------------------------------------

Ship it!


Looks good.  Thanks for getting this patched so fast.

- Matt


On Dec. 8, 2011, 3:10 p.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1615/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2011, 3:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> http://bamboo.asterisk.org/browse/AST10-LUCID-AMD64-384
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 347652 
> 
> Diff: https://reviewboard.asterisk.org/r/1615/diff
> 
> 
> Testing
> -------
> 
> After applying, I get this:
> 
> 
> $ sudo ./runtests.py -t tests/channels/SIP/sip_tls_register
> Running tests for Asterisk SVN-branch-1.8-r347595M ...
> 
> --> Running test 'tests/channels/SIP/sip_tls_register' ...
> 
> Making sure Asterisk isn't running ...
> Running ['tests/channels/SIP/sip_tls_register/run-test'] ...
> Parsing /tmp/asterisk-testsuite/channels/SIP/sip_tls_register/ast8/etc/asterisk/extconfig.conf
> Parsing /tmp/asterisk-testsuite/channels/SIP/sip_tls_register/ast8/etc/asterisk/logger.conf
> Parsing /tmp/asterisk-testsuite/channels/SIP/sip_tls_register/ast8/etc/asterisk/logger.general.conf.inc
> Parsing /tmp/asterisk-testsuite/channels/SIP/sip_tls_register/ast8/etc/asterisk/logger.logfiles.conf.inc
> [Dec 08 22:07:23] WARNING[13342]: asterisk.TestCase:217 __reactor_timeout: Reactor timeout: '30' seconds
> <?xml version="1.0" encoding="utf-8"?>
> <testsuite errors="0" failures="0" name="AsteriskTestSuite" tests="1" time="37.80">
>   <testcase name="tests/channels/SIP/sip_tls_register" time="37.80"/>
> </testsuite>
> 
> 
> I don't like the reactor timeout, but the test claims to have succceded.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111208/1efd81e9/attachment-0001.htm>