[asterisk-dev] [Code Review] Add the install path of astdb2sqlite3 to paths.h to avoid relying on $PATH when doing automatic astdb conversion

Paul Belanger reviewboard at asterisk.org
Wed Dec 7 12:19:06 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1613/#review4955
-----------------------------------------------------------

Ship it!


upgrade works


/branches/10/Makefile
<https://reviewboard.asterisk.org/r/1613/#comment9214>

    well played sir


- Paul


On Dec. 7, 2011, 11:44 a.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1613/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2011, 11:44 a.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> Before patch: Asterisk relies on $PATH to execute astdb2sqlite3 for astdb conversion
> After patch: It doesn't
> 
> 
> This addresses bug ASTERISK-18959.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18959
> 
> 
> Diffs
> -----
> 
>   /branches/10/Makefile 347343 
>   /branches/10/build_tools/make_defaults_h 347343 
>   /branches/10/configs/asterisk.conf.sample 347343 
>   /branches/10/include/asterisk/paths.h 347343 
>   /branches/10/main/asterisk.c 347343 
>   /branches/10/main/db.c 347343 
> 
> Diff: https://reviewboard.asterisk.org/r/1613/diff
> 
> 
> Testing
> -------
> 
> Delete astdb.sqlite3. Run Asterisk. astdb.sqlite3 exists. No errors.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111207/65f30a62/attachment.htm>


More information about the asterisk-dev mailing list