[asterisk-dev] [Code Review] Add the install path of astdb2sqlite3 to paths.h to avoid relying on $PATH when doing automatic astdb conversion

Terry Wilson reviewboard at asterisk.org
Tue Dec 6 21:16:08 CST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 6, 2011, 9:16 p.m.)

Review request for Asterisk Developers and Paul Belanger.


Changed to making the ASTSBINDIR available. Also changed astcanary to use it (and tested that it worked). Also added Makefile dependency for make_defaults_h for defaults.h target so that changes to make_defaults_h prompt it to be recreated.


Before patch: Asterisk relies on $PATH to execute astdb2sqlite3 for astdb conversion
After patch: It doesn't

This addresses bug ASTERISK-18959.

Diffs (updated)

  /branches/10/Makefile 347057 
  /branches/10/build_tools/make_defaults_h 347057 
  /branches/10/include/asterisk/paths.h 347057 
  /branches/10/main/asterisk.c 347057 
  /branches/10/main/db.c 347057 

Diff: https://reviewboard.asterisk.org/r/1613/diff


Delete astdb.sqlite3. Run Asterisk. astdb.sqlite3 exists. No errors.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111207/9f7dd46e/attachment.htm>

More information about the asterisk-dev mailing list