[asterisk-dev] [Code Review]: Add the install path of astdb2sqlite3 to paths.h to avoid relying on $PATH when doing automatic astdb conversion

[Terry Wilson]

> On Dec. 6, 2011, 6:32 p.m., Tilghman Lesher wrote:
> > Why not just encode the sbin directory as a standard path, then use that?  Seems rather limiting to create a single-use path.  While you're at it, you could modify the code in asterisk.c for astcanary to use that same path.

I thought about it, but couldn't think of anything else we would need it for and decided to match it up with how the AST_DB path worked. If astcanary can benefit from it as well, then that tilts things in favor of making the directory available. Will do.


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1613/#review4946
-----------------------------------------------------------


On Dec. 6, 2011, 5:18 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1613/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2011, 5:18 p.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> Before patch: Asterisk relies on $PATH to execute astdb2sqlite3 for astdb conversion
> After patch: It doesn't
> 
> 
> This addresses bug ASTERISK-18959.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18959
> 
> 
> Diffs
> -----
> 
>   /branches/10/build_tools/make_defaults_h 347057 
>   /branches/10/include/asterisk/paths.h 347057 
>   /branches/10/main/asterisk.c 347057 
>   /branches/10/main/db.c 347057 
> 
> Diff: https://reviewboard.asterisk.org/r/1613/diff
> 
> 
> Testing
> -------
> 
> Delete astdb.sqlite3. Run Asterisk. astdb.sqlite3 exists. No errors.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111207/cb81f36f/attachment.htm>