[asterisk-dev] [Code Review]: Add MixMonitor and StopMixMonitor AMI actions

[jrose]

> On Dec. 5, 2011, 2:28 p.m., David Vossel wrote:
> > http://svn.asterisk.org/svn/asterisk/branches/1.8/apps/app_mixmonitor.c, lines 161-191
> > <https://reviewboard.asterisk.org/r/1193/diff/4/?file=16231#file16231line161>
> >
> >     The available options here are out of sync with the ones actually present in Asterisk Trunk now.  In order not to have to maintain the documentation for these options twice, it may be worth just indicating that the options field is the same one used in the MixMonitor dialplan application.
> >     
> >     It really doesn't matter to me which way we go, but if we decide to put in documentation here for each available option it needs to be up to date.

On this, I'd say go with the 'same ones used in the MixMonitor dialplan application' approach.  Easier in the long run and the only obvious benefit to it is that you'd know what options were available using the 'manager show command MixMonitor' CLI command... which isn't that much more convenient than issuing 'core show application mixmonitor'


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1193/#review4919
-----------------------------------------------------------


On April 21, 2011, 9:29 a.m., telecos82 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1193/
> -----------------------------------------------------------
> 
> (Updated April 21, 2011, 9:29 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add MixMonitor and StopMixMonitor AMI actions to allow starting and stopping MixMonitor from AMI.
> 
> 
> This addresses bug 19155.
>     https://issues.asterisk.org/jira/browse/19155
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/branches/1.8/apps/app_mixmonitor.c 314406 
> 
> Diff: https://reviewboard.asterisk.org/r/1193/diff
> 
> 
> Testing
> -------
> 
> Tested with SIP, IAX and DAHDI channels.
> 
> 
> Thanks,
> 
> telecos82
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111205/a822e23f/attachment.htm>