[asterisk-dev] [Code Review]: create testsuite tests for r1533

[wdoekes]

> On Dec. 2, 2011, 3:56 p.m., Terry Wilson wrote:
> > Code looks good. I'm checking with Paul about sipp 3.2 on bamboo test agents, etc.

I'll drop the timeout_error option for now, do the s/to/so and commit it.


> On Dec. 2, 2011, 3:56 p.m., Terry Wilson wrote:
> > /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test, line 67
> > <https://reviewboard.asterisk.org/r/1606/diff/3/?file=22089#file22089line67>
> >
> >     My version of sipp (sip-tester 3.1-3 package from Ubuntu 11.10) doesn't have this option. I notice that 3.2  was released on sf.net in 2010, so I guess 3.1 is really old. I'm not sure if any of the other tests rely on sipp 3.2 features, so it is at least something we need to be aware of or this will fail on any bamboo agent with an older sipp.

Oh. We don't need to upgrade solely for this option. I can just as easily remove it. I added it simply because it's in my standard set of options.

(Personally I use this one https://code.osso.nl/projects/sipp which fixes that timeout_error *always* works.)


- wdoekes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1606/#review4911
-----------------------------------------------------------


On Dec. 2, 2011, 10:56 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1606/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2011, 10:56 a.m.)
> 
> 
> Review request for Asterisk Developers and Terry Wilson.
> 
> 
> Summary
> -------
> 
> Created a test suite for the REGISTER problems of r1533:
> 
> 
> SCENARIO_TABLE = (
>     ('USER',    'SECRET',       'USERADDR',                 'RESP'),
> 
>     ('baduser', 'badsecret',    'baduser at mydom.com',        403), # authreject
>     ('baduser', 'badsecret',    'baduser at 127.0.0.1',        403), # bad both
> 
>     ('someuser', 'somesecret',  'someuser at mydom.com',       200), # ok
>     ('someuser', 'badsecret',   'someuser at mydom.com',       403), # bad pass
>     ('someuser', 'somesecret',  'someuser at mydom2.com',      200), # ok
>     ('someuser', 'somesecret',  'someuser at mydom3.com',      403), # bad domain
>     ('someuser', 'somesecret',  'someuser@',                404), # bad sip
>     ('someuser', 'somesecret',  '@someuser',                403), # bad dom/sip
> 
>     ('mydom.com', 'mysecret',   'mydom.com at mydom.com',      200), # ok
>     ('mydom.com', 'mysecret',   'mydom.com at mydom2.com',     200), # ok
>     ('mydom.com', 'mysecret',   'mydom.com',                200), # ok(!)
>     ('mydom.com', 'mysecret',   'mydom.com@',               404), # not ok
>     #('mydom.com', 'mysecret',   '@mydom.com',               200), # ok(BAH!)
> )
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/sipp.py 2817 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg200.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg403.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg404.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 2817 
> 
> Diff: https://reviewboard.asterisk.org/r/1606/diff
> 
> 
> Testing
> -------
> 
> Before applying r1533:
>   6 errors
> After:
>   0 errors
> 
> Changes between pre-r1533:
> - 404 ('baduser', 'badsecret',    'baduser at 127.0.0.1',        403)
> - 404 ('someuser', 'somesecret',  'someuser at mydom3.com',      403)
> - 401/200 ('someuser', 'somesecret',  'someuser@',            404)
> - 404 ('someuser', 'somesecret',  '@someuser',                403)
> - 403 ('mydom.com', 'mysecret',   'mydom.com',                200)
> - 401/200 ('mydom.com', 'mysecret',   'mydom.com@',           404)
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111203/4c7bec98/attachment.htm>