<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1606/">https://reviewboard.asterisk.org/r/1606/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 2nd, 2011, 3:56 p.m., <b>Terry Wilson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code looks good. I'm checking with Paul about sipp 3.2 on bamboo test agents, etc.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll drop the timeout_error option for now, do the s/to/so and commit it.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 2nd, 2011, 3:56 p.m., <b>Terry Wilson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1606/diff/3/?file=22089#file22089line67" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> '-timeout_error',</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My version of sipp (sip-tester 3.1-3 package from Ubuntu 11.10) doesn't have this option. I notice that 3.2 was released on sf.net in 2010, so I guess 3.1 is really old. I'm not sure if any of the other tests rely on sipp 3.2 features, so it is at least something we need to be aware of or this will fail on any bamboo agent with an older sipp.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh. We don't need to upgrade solely for this option. I can just as easily remove it. I added it simply because it's in my standard set of options.
(Personally I use this one https://code.osso.nl/projects/sipp which fixes that timeout_error *always* works.)</pre>
<br />
<p>- wdoekes</p>
<br />
<p>On December 2nd, 2011, 10:56 a.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Terry Wilson.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2011, 10:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created a test suite for the REGISTER problems of r1533:
SCENARIO_TABLE = (
('USER', 'SECRET', 'USERADDR', 'RESP'),
('baduser', 'badsecret', 'baduser@mydom.com', 403), # authreject
('baduser', 'badsecret', 'baduser@127.0.0.1', 403), # bad both
('someuser', 'somesecret', 'someuser@mydom.com', 200), # ok
('someuser', 'badsecret', 'someuser@mydom.com', 403), # bad pass
('someuser', 'somesecret', 'someuser@mydom2.com', 200), # ok
('someuser', 'somesecret', 'someuser@mydom3.com', 403), # bad domain
('someuser', 'somesecret', 'someuser@', 404), # bad sip
('someuser', 'somesecret', '@someuser', 403), # bad dom/sip
('mydom.com', 'mysecret', 'mydom.com@mydom.com', 200), # ok
('mydom.com', 'mysecret', 'mydom.com@mydom2.com', 200), # ok
('mydom.com', 'mysecret', 'mydom.com', 200), # ok(!)
('mydom.com', 'mysecret', 'mydom.com@', 404), # not ok
#('mydom.com', 'mysecret', '@mydom.com', 200), # ok(BAH!)
)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before applying r1533:
6 errors
After:
0 errors
Changes between pre-r1533:
- 404 ('baduser', 'badsecret', 'baduser@127.0.0.1', 403)
- 404 ('someuser', 'somesecret', 'someuser@mydom3.com', 403)
- 401/200 ('someuser', 'somesecret', 'someuser@', 404)
- 404 ('someuser', 'somesecret', '@someuser', 403)
- 403 ('mydom.com', 'mysecret', 'mydom.com', 200)
- 401/200 ('mydom.com', 'mysecret', 'mydom.com@', 404)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/sipp.py <span style="color: grey">(2817)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg200.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg403.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/sipp/reg404.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/sip_register_domain_acl/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/tests.yaml <span style="color: grey">(2817)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1606/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>