[asterisk-dev] [Code Review]: Review directed pickup test using TestCase class

[Paul Belanger]

> On Aug. 30, 2011, 10:27 a.m., jrose wrote:
> > Does this test need manager.general.conf.inc?  Using default config files from make samples on my machine, I always get ami login errors if I don't include one.
> 
> Paul Belanger wrote:
>     Yes, this is a result of a bad svn diff.  But it file does exist in my branch
>

In fact, I'm thinking up updating our default testsuite configuration files to enable the manager by default. Then we don't have to work about that configuration file, unless you want explicitly disable it.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1401/#review4187
-----------------------------------------------------------


On Aug. 30, 2011, 8:05 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1401/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2011, 8:05 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Directed pickup is failing under FreeBSD, so I decided to look at it and then rewrite it.  It now uses the TestCase class allowing us to inherit the python logging class. The test now monitor AMI events, to confirm the directed pickup happens, rather then timing.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/directed_pickup/configs/ast1/extensions.conf 1972 
>   asterisk/trunk/tests/directed_pickup/run-test 1972 
> 
> Diff: https://reviewboard.asterisk.org/r/1401/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110830/768023ff/attachment.htm>