[asterisk-dev] [Code Review] Review directed pickup test using TestCase class

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1401/#review4179
-----------------------------------------------------------



asterisk/trunk/tests/directed_pickup/run-test
<https://reviewboard.asterisk.org/r/1401/#comment8220>

    I've also removed this 2nd test, I was not happen how it was implemented.  Depending on the results of this test, I'll create a second adding back this test.


- Paul


On Aug. 30, 2011, 8:05 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1401/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2011, 8:05 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Directed pickup is failing under FreeBSD, so I decided to look at it and then rewrite it.  It now uses the TestCase class allowing us to inherit the python logging class. The test now monitor AMI events, to confirm the directed pickup happens, rather then timing.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/directed_pickup/configs/ast1/extensions.conf 1972 
>   asterisk/trunk/tests/directed_pickup/run-test 1972 
> 
> Diff: https://reviewboard.asterisk.org/r/1401/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110830/59f58199/attachment.htm>